embedded table: use DOMAIN to look up the resource fields

pyeve / eve-sqlalchemy

SQLAlchemy data layer for Eve-powered RESTful APIs

http://eve-sqlalchemy.readthedocs.io

Other

232 stars 70 forks source link

embedded table: use DOMAIN to look up the resource fields #45

Closed goneri closed 9 years ago

goneri commented 9 years ago

This patch resolve two issues:

it's now possible to have a resource field that is a relation to another relation, even if the name doesn't match. For example, product_stable and product_devel are two one-to-one field with a relationship to product
when we associate a foreign resource, we skip the foreign_resource field to avoid endless loop. For example, a any-to-one relation called foo with an associate to bar that we pull with embedded. bar has got a foo_collection with a link to foo. Previously, the foo_collection filed was automatically added in the list of field of bar. This was enough to create an endless loop in lookup_foreign_resource.

coveralls commented 9 years ago

Coverage decreased (-0.76%) to 97.16% when pulling 01cd3681f56ab169b47b3e19cd79a774824b2a31 on goneri:embedded_with_DOMAIN into 3c8780b2f053b9fa992d3d0ddd7494a286e87a41 on RedTurtle:master.

coveralls commented 9 years ago

Coverage decreased (-0.77%) to 97.15% when pulling 819f98ce3e2a0932f4486410ec5eeb8bb22cfe3f on goneri:embedded_with_DOMAIN into 3c8780b2f053b9fa992d3d0ddd7494a286e87a41 on RedTurtle:master.

coveralls commented 9 years ago

Coverage decreased (-0.72%) to 97.2% when pulling d6912d0e6e669e3d0c01309e42ab236b60ee26df on goneri:embedded_with_DOMAIN into 3c8780b2f053b9fa992d3d0ddd7494a286e87a41 on RedTurtle:master.

coveralls commented 9 years ago

Coverage decreased (-0.72%) to 97.2% when pulling d6912d0e6e669e3d0c01309e42ab236b60ee26df on goneri:embedded_with_DOMAIN into 3c8780b2f053b9fa992d3d0ddd7494a286e87a41 on RedTurtle:master.

coveralls commented 9 years ago

Coverage decreased (-0.72%) to 97.2% when pulling d6912d0e6e669e3d0c01309e42ab236b60ee26df on goneri:embedded_with_DOMAIN into 3c8780b2f053b9fa992d3d0ddd7494a286e87a41 on RedTurtle:master.

coveralls commented 9 years ago

Coverage decreased (-0.72%) to 97.2% when pulling d6912d0e6e669e3d0c01309e42ab236b60ee26df on goneri:embedded_with_DOMAIN into 3c8780b2f053b9fa992d3d0ddd7494a286e87a41 on RedTurtle:master.

coveralls commented 9 years ago

Coverage decreased (-0.72%) to 97.2% when pulling d6912d0e6e669e3d0c01309e42ab236b60ee26df on goneri:embedded_with_DOMAIN into 3c8780b2f053b9fa992d3d0ddd7494a286e87a41 on RedTurtle:master.

kiniou commented 9 years ago

:+1: Those changes looks good to me but i think it might need some other test cases.

amleczko commented 9 years ago

I like this PR, but it looks backward incompatible. My suggestion:

update documentation about it
add more tests If you want I can add tests if you update docs :) And it can go the next release

goneri commented 9 years ago

Hi @amleczko and @kiniou

I refreshed the patch:

it comes with an embedded section in the documentation
a better (complet?) coverage.

coveralls commented 9 years ago

Coverage decreased (-0.72%) to 97.2% when pulling 7c0b126bd84c31a2c2f26e4ad6e79c65502a9fb3 on goneri:embedded_with_DOMAIN into 3c8780b2f053b9fa992d3d0ddd7494a286e87a41 on RedTurtle:master.

coveralls commented 9 years ago

Coverage decreased (-0.72%) to 97.2% when pulling 7c0b126bd84c31a2c2f26e4ad6e79c65502a9fb3 on goneri:embedded_with_DOMAIN into 3c8780b2f053b9fa992d3d0ddd7494a286e87a41 on RedTurtle:master.

goneri commented 9 years ago

@amleczko @kiniou is this PR fine for you now?

amleczko commented 9 years ago

Yes it looks pretty decent. I will check it with one of my live projects and eventually write more test cases (I will keep you updated).

goneri commented 9 years ago

hi @amleczko,

Do you have some feedback regarding this PR?

goneri commented 9 years ago

I may have a better fix. I close the PR for the moment.