search

pyeve / eve-sqlalchemy

SQLAlchemy data layer for Eve-powered RESTful APIs
http://eve-sqlalchemy.readthedocs.io
Other
232 stars 70 forks source link

Allow to supply own Flask-SQLAlchemy driver to SQL data layer #86

Closed fubu closed 6 years ago

fubu commented 8 years ago

fixes #85

dkellner commented 7 years ago

I know it's late to answer this pull request, but I just recently got the right to merge those. So let's get to work :).

Your explanations in #85 sound plausible and I will merge this before releasing 0.5. Do you think it's feasable to include a test for this?

bitfinity commented 6 years ago

A simple thing like this can't be fixed in 3 years? I mean Eve looks great, but considering I use a SQL database, I probably won't use it unless I want to fork this repo and fix it, which is more work than using another less convenient framework.

dkellner commented 6 years ago

@bitfinity Instead of looking into another framework, you could start by rebasing this PR on current master and include a test for the new functionality. I'd be happy to merge it.

bitfinity commented 6 years ago

@dkellner I would if I had time. It looks like a good framework. Unfortunately my deadline for the entire backend REST service I'm working on is like 3 weeks from now.

dkellner commented 6 years ago

@bitfinity Which frameworks do you consider to use for your project apart from Eve, and why?

dkellner commented 6 years ago

Merged after rebase.

nicolaiarocci commented 6 years ago

This was a show blocker for us on the current stable. Had to pull the dev version to get going.