search

pyeve / eve-swagger

Swagger extension for Eve-powered RESTful APIs
http://python-eve.org
Other
154 stars 43 forks source link

Implement openapi 3.0 specification. #70

Closed rmlopes closed 5 years ago

rmlopes commented 6 years ago

Plus: Add sub-resource path parameters documentation. Add security definitions for eve-oauth extension. Use resource example only for requestBody parameters (responses use the schema based example). Add reusable IfMatch parameter.

Open to discussion.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sergekir commented 5 years ago

Any plans on merging it?

nicolaiarocci commented 5 years ago

Yes, I plan on reviewing this (and other stuff) once I have some extra time to work on the eve ecosystem.

nicolaiarocci commented 5 years ago

Howdy!

I am sorry for the long wait @rmlopes and @sergekir. Since some time has passed, do any of you have anything to add/comment about this pull request?

rmlopes commented 5 years ago

Hi Nicola,

I have kept a branch for this PR and in the meanwhile have made other improvements that I needed for my project. These included support for the valueschema properties and support for static documentation using redoc. I just merged them into master this morning and I can create another PR for comparison if you wish. I think it is still pertinent whether this should be an upgrade for eve-swagger or rather a new extension.

EDIT: not sure what is going on with the flake8 test, it is returning an error at the email regex on validation.py, but it is successful when I run it on my machine.

nicolaiarocci commented 5 years ago

Please submit a new PR, I will gladly review it.

nicolaiarocci commented 5 years ago

@rmlopes ping, just to make sure work is still ongoing here.