search

pyeve / eve-swagger

Swagger extension for Eve-powered RESTful APIs
http://python-eve.org
Other
154 stars 43 forks source link

add the URL_PREFIX to the swagger url if applicable #95

Closed AnthonyCaetano closed 4 years ago

AnthonyCaetano commented 5 years ago

Prefix the swagger url with the URL_PREFIX if it is configured: https://github.com/pyeve/eve-swagger/issues/94

AnthonyCaetano commented 5 years ago

Ok, but surely eve-swagger should work by default in the non-proxied environment first? Then deployment issues that you had should be attempted to be resolved after?

I tried setting app.config['SWAGGER_HOST'] = "%s/%s" % (request.host_url, URL_PREFIX) but I can't do this outside of request context. Using SERVER_NAME I need to hard-code the http/https scheme... which means localhost and deployed prod work differently and I need configure them differently when being proxied vs being callled in development directly... Is this the intention?
It seems a bit lame since I don't need to that for Eve itself.
But I am new at this game so maybe I am missing something...

No worries, I will use my fork till I understand things better.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.