search

pyeventsourcing / eventsourcing

A library for event sourcing in Python.
https://eventsourcing.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.41k stars 129 forks source link

comments and suggestions on the tutorial #241

Closed sfinnie closed 2 years ago

sfinnie commented 2 years ago

not mergeable in current form. Comments delineated by COMMENT/END COMMENT blocks. Suggestions in line.

Page 3 might warrant some re-structuring. It covers quite a wide breadth, from applications to persistence to notifications to the concepts of command and query methods.

Overall though the tutorial is great. It provides a a very gradual intro to aggregates and applications, plus just enough on the mechanics to help the user understand how things work.

johnbywater commented 2 years ago

Thanks for all your hard work on this @sfinnie. As you said it wasn't mergeable in its current form. But as discussed privately, I have tried to resolve the concerns in other commits. Please do submit PRs for any outstanding or any other issues you see. Small PRs are more easily and will be more quickly merged than large ones. I look forward to your future contributions to this project.