search

pyexcel / pyexcel-io

One interface to read and write the data in various excel formats, import the data into and export the data from databases
http://io.pyexcel.org
Other
58 stars 20 forks source link

New style plugin - reader #73

Closed chfw closed 4 years ago

chfw commented 4 years ago

Inheritance -> Composition to do better information hiding. At large, to comply with Open and Closed principle.

Old book reader is separated into 3 sub types: file, memory and content reader. Old sheet reader is separated as: pyexcel-io's sheet reader and native sheet reader.

write plugins will follow suite. this PR will allow the 0.5.x plugins to do regression testing.

codecov-commenter commented 4 years ago

Codecov Report

Merging #73 into dev will decrease coverage by 0.71%. The diff coverage is 97.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #73      +/-   ##
==========================================
- Coverage   96.35%   95.63%   -0.72%     
==========================================
  Files          44       47       +3     
  Lines        3126     3252     +126     
==========================================
+ Hits         3012     3110      +98     
- Misses        114      142      +28
Impacted Files Coverage Δ
pyexcel_io/readers/csvr.py 95.32% <80.00%> (-3.60%) :arrow_down:
pyexcel_io/readers/tsv.py 81.81% <83.33%> (-18.19%) :arrow_down:
pyexcel_io/plugins.py 95.87% <94.59%> (+0.79%) :arrow_up:
pyexcel_io/readers/csv_file_reader.py 97.14% <97.14%> (ø)
pyexcel_io/readers/csv_memory_reader.py 97.43% <97.43%> (ø)
pyexcel_io/io.py 99.08% <100.00%> (+0.03%) :arrow_up:
pyexcel_io/reader.py 97.29% <100.00%> (+5.63%) :arrow_up:
pyexcel_io/readers/__init__.py 100.00% <100.00%> (ø)
pyexcel_io/readers/csv_content_reader.py 100.00% <100.00%> (ø)
pyexcel_io/readers/csvz.py 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc30cce...d27b785. Read the comment docs.