pyexcel / pyexcel-xlsx

A wrapper library to read, manipulate and write data in xlsx and xlsm format using openpyxl
Other
115 stars 32 forks source link

setup: make a universal wheel #16

Closed benoit-pierre closed 7 years ago

benoit-pierre commented 7 years ago

Default to creating an universal wheel.

codecov-io commented 7 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files           9        9           
  Lines         523      523           
=======================================
  Hits          516      516           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0ba14f...e3cf54c. Read the comment docs.

chfw commented 7 years ago

Can you share with me the usage of "bdist_wheel" in your perspective? I am afraid I am not a user of wheels yet.

benoit-pierre commented 7 years ago

The http://pythonwheels.com/ site sums it up nicely:

Advantages of wheels:

  1. Faster installation for pure python and native C extension packages.
  2. Avoids arbitrary code execution for installation. (Avoids setup.py)
  3. Installation of a C extension does not require a compiler on Windows or macOS.
  4. Allows better caching for testing and continuous integration.
  5. Creates .pyc files as part of installation to ensure they match the python interpreter used.
  6. More consistent installs across platforms and machines.

For Plover we cache wheels of our dependencies to reduce build times on Travis CI/AppVeyor. We're also going to use setuptools' entrypoints for plugins, and pip to install those plugins, so avoiding 2 and 3 is pretty critical:

chfw commented 7 years ago

Thanks for the sharing. I am starting to distribute wheels now.