Allow for set and other unsubscriptable data structures.

pyexcel / pyexcel-xlsx

A wrapper library to read, manipulate and write data in xlsx and xlsm format using openpyxl

Other

115 stars 32 forks source link

Allow for set and other unsubscriptable data structures. #53

Open craiga opened 1 year ago

craiga commented 1 year ago

An attempt to fix https://github.com/pyexcel/pyexcel-xlsx/issues/52

With your PR, here is a check list:

[x] Has test cases written?
[x] Has all code lines tested?
[x] Has make format been run?
[x] Please update CHANGELOG.yml(not CHANGELOG.rst)
[x] Has fair amount of documentation if your change is complex
[x] Agree on NEW BSD License for your contribution

craiga commented 1 year ago

Some tests are still failing here on my machine and I'm not sure whether this is due to my environment, whether my change has has an unintended consequence, or whether an update to some other library is causing an issue in the tests.

Is there CI or anything similar this can be run through to get a clear view on this?

kodurusivakumar34 commented 1 year ago

can you someone try to merge this fix?

kodurusivakumar34 commented 1 year ago

@craiga can you please try to merge this pull request

craiga commented 1 year ago

@kodurusivakumar34 I don't have write permissions here, that'd be a job for @chfw I believe.

kodurusivakumar34 commented 1 year ago

@chfw can you please review and merge this PR

Mokatsu commented 1 year ago

What's the status on this merge?