pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 409 forks source link

Link has no effect on projected remote rep, damper, tracking disruptors #1009

Open light007 opened 7 years ago

light007 commented 7 years ago

Bug Report

Expected behavior:

Link should have effect on projected remote rep, damper, tracking disruptors.

Actual behavior:

Link has no effect on projected remote rep, damper, tracking disruptors. Here is an example for remote rep. r 3uqkhwtn yv2k2y9wt kq i1il i3p trbeql7 d lwa

Detailed steps to reproduce:

  1. Pull Guardian fit to projected area.
  2. Pull Astarte booster2 fit to command area.

Fits involved in EFT format (Edit > To Clipboard > EFT):

[Guardian, Guardian]

[Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot]

[Empty Med slot] [Empty Med slot]

Large Remote Armor Repairer II [Empty High slot] [Empty High slot] [Empty High slot] [Empty High slot] [Empty High slot]

[Empty Rig slot] [Empty Rig slot]

[Astarte, Astarte booster2]

[Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot]

[Empty Med slot] [Empty Med slot] [Empty Med slot] [Empty Med slot]

Armor Command Burst II, Armor Reinforcement Charge Armor Command Burst II, Armor Energizing Charge Armor Command Burst II, Rapid Repair Charge [Empty High slot] [Empty High slot] [Empty High slot] [Empty High slot]

Medium Command Processor I [Empty Rig slot]

Guardian has no implant. Astarte booster2 has a Federation Navy command Mindlink

Release or development git branch? Please note the release version or commit hash:

pyfa version is pyfa-1.27.0-yc119.2-1.2-win.zip

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

Operating system is Windows 10

Other relevant information:

PS: It could be better if you could set distance in projected. Such as target painter effects has a big different from 80 km to 20 km. PS2: I hope there is a overheat time display when you overheat something just like EFT.

blitzmann commented 7 years ago

Thanks for the report, I'll look into it hopefully tonight. :)

blitzmann commented 7 years ago

So, just to be clear: you're using self projection on this Guardian, right? using the same fit to project onto it?

As to the other points:

PS: It could be better if you could set distance in projected. Such as target painter effects has a big different from 80 km to 20 km.

There's a way to do it via graphs, but we haven't gotten that far with it. At the moment, ewar and energy 'falloff' doesn't apply in pyfa

PS2: I hope there is a overheat time display when you overheat something just like EFT.

See #445. There isn't a way to reliably do this as heat is chance-based. EFT is probably pulling numbers out of it's ass (or doing an average or something). We dont have a good algorithm to do it (that I'm aware of anyway)

blitzmann commented 7 years ago

Can confirm issue. First thought is that the projected effect runs before the command effect, so it doesn't have it's boost yet...

This might be a tricky one to fix unfortunately...

We really should make it so that projected effects are done at the very last bit in the fit calculation to avoid issues like this. Like, cache the effect to be run after the runtimes... I'll take a look into this more indepth in the coming days, but this probably wont be fixed with the point release this weekend :(

Asday commented 3 years ago

I've noticed weirdness similar to this myself, usually when projecting fit A onto fit B, then modifying fit A and switching back to fit B, it will act as if fit A is no longer projected at all, and I have to do the trusty ol' turn it off and on again to fix it.

If that's unrelated, ignore me. I might chase my issue down in future and open up a real issue (or PR) for it.