pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 406 forks source link

Double click on empty element causes an exception #1179

Closed unti1x closed 7 years ago

unti1x commented 7 years ago
  1. Open "Command" or "Projected" tab
  2. Double click empty element

Screenshot

OS version:     Linux-4.4.0-78-generic-x86_64-with-Ubuntu-16.04-xenial
Python:     2.7.12
wxPython:   3.0.2.0
SQLAlchemy:     1.0.11
Logbook:    1.0.0
pyfa version: 1.29.2 Stable - YC119.5 1.0
pyfa root: /usr/share/games/pyfa
save path: /home/unti1x/.pyfa
fs encoding: UTF-8

EXCEPTION: 'NoneType' object has no attribute 'ID'

  File "/usr/share/games/pyfa/gui/commandView.py", line 217, in remove
    sFit.removeCommand(fitID, self.get(row))
  File "/usr/share/games/pyfa/service/fit.py", line 506, in removeCommand
    del fit.__commandFits[thing.ID]
blitzmann commented 7 years ago

Thanks for the report! There's an automated build which include a fix for this here in case you're interested https://ci.appveyor.com/project/blitzmann/pyfa/build/artifacts

:D