pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.6k stars 406 forks source link

An error in the calculations amount of the capital fighters in hangar #1277

Open Packuh opened 6 years ago

Packuh commented 6 years ago

Submit a bug report bug report or feature request

Here you can inform pyfa developers of potential bugs or suggest features / improvements to the project. Please check to make sure that the bug hasn't been reported or feature requested before submitting. If you have general questions about the project and want to reach out to the developers personally, please check out out our [Slack] (https://pyfainvite.azurewebsites.net/).


Bug Report

Expected behavior:

http://c2n.me/3NCso4Z

Actual behavior:

http://c2n.me/3NCsvTR

Detailed steps to reproduce:

Pyfa does not correctly calculate the amount of fighter

Fits involved in EFT format (Edit > To Clipboard > EFT):

[Nyx, Test server]

[Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot]

[Empty Med slot] [Empty Med slot] [Empty Med slot] [Empty Med slot] [Empty Med slot]

[Empty High slot] [Empty High slot] [Empty High slot] [Empty High slot] [Empty High slot] [Empty High slot]

[Empty Rig slot] [Empty Rig slot] [Empty Rig slot]

Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Tyrfing II x6 Gram II x12 Gram II x12 Gram II x12 Gram II x12 Gram II x12 Gram II x12

Release or development git branch? Please note the release version or commit hash:

Last yc119.8 1.0

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

win 10

Other relevant information:

ghost commented 6 years ago

@Packuh In your in game screenshot you have 18 bombers and 24 fighters loaded into launch tubes. I don't fly a super but I'm pretty sure that fighters in your tubes do not count towards your capacity.

Pyfa calculates the used capacity for all the fighters even ones that are active which is why the total appears higher, as it has no way to distinguish between active fighters in space and active fighters in tubes.

blitzmann commented 6 years ago

What @burnsypet said. I can fly a few supers, but don't have an active account anymore to actually get in one, even on the test server, and I don't remember the mechanics well enough. However. I can see why you may want to say "what is the absolute max number of fighters I can support..." in which case we might be able to subtract the number of "active" fighters from the total volume. I'll take a peak at the code to see how easy it would be to address that.

Packuh commented 6 years ago

hi, http://c2n.me/3O2t1Uq 1 - MAX mass fighter hangar. He dont stack with fighter in img2 img2 - http://c2n.me/3O2th01

http://c2n.me/3O2tljP + http://c2n.me/3O2tuq3 = http://c2n.me/3O2tEZJ

My skill for hangar ammount = 5 (max) = for Super Mather Ship Nyx = 137 500 m3

Volume: Heavy fighters http://c2n.me/3O2uj1f Light fighters http://c2n.me/3O2usqc Support fighters http://c2n.me/3O2uxdk

I can use in one time only 5 squad http://c2n.me/3O2uJne 1 - in one time max Light fighters=3 squad 2 - in one time max Support fighters=2 squad 3 - in one time max heavy fighter=3 squad But in one time i can only 5 squad. Therefore, it is necessary to choose which fighters to take with them.

Fighter uploaded to the launch bay does not occupy the volume of the hangar for the fighters. Those. in the Compartment for launching the fighters, the main thing is only the number of fighters in each squad and the volume of the fighter is not important. but the hangar of the fighters is calculated from the pilot's skill and can be changed. And in it it is important how much and what kind of fighters in it lies. Fighter downloaded for launch and fighter in the hangar of fighters are different fighter. Therefore, for the fighters in the hangar, both the volume and the number of these fighters are important. And for fighters loaded into squads for startup, only the count and type of fighters are important, the volume in this case is no longer important, and the volume in this case is not correctly summed with the volume of fighters in the hangar.

in 1 squad for the launch can be set number of fighters: Heavy fighters: http://c2n.me/3O2vCc8 Support fighters: http://c2n.me/3O2vEYR Light fighters http://c2n.me/3O2vN8j

And Zero fighter hangar http://c2n.me/3O2AlFr

And Other Wyvern: http://c2n.me/3O2AJbG Aeon: http://c2n.me/3O2AP3m Hel: http://c2n.me/3O2ARU9