pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 409 forks source link

Grant Missing Skills (when strict skill levels is on) misses a few #1289

Closed blitzmann closed 7 years ago

blitzmann commented 7 years ago

While looking into #1273, I noticed that, while not exactly the same issue, there is some sort of issue revolving around the grant missing skills option.

Copy all 0 character and apply to this fit:

[Sabre, Sabre]

Damage Control II
Nanofiber Internal Structure II

Medium Azeotropic Restrained Shield Extender
5MN Y-T8 Compact Microwarpdrive
Initiated Compact Warp Scrambler
Medium Shield Extender II

Prototype Cloaking Device I
125mm Gatling AutoCannon II
125mm Gatling AutoCannon II
125mm Gatling AutoCannon II
125mm Gatling AutoCannon II
125mm Gatling AutoCannon II
125mm Gatling AutoCannon II
Interdiction Sphere Launcher I, Warp Disrupt Probe

Small Hyperspatial Velocity Optimizer II
Small Hyperspatial Velocity Optimizer II

Warp Disrupt Probe x46

This is the skill list:

image

Grant missing skills, these skills are still needed:

image

This is all assuming strict skills are enabled

ghost commented 7 years ago

I added some traces to characterSelection.py and it looks like grantMissingSkills is not considering skills deeper in the tree, eg. 11579 "Cloaking" is considered however it's requirement 3426 "CPU Management" is not.

_buildSkillsTooltipCondensed seems to traverse all the skill requirements, and I have made an amendment on a local version to re-use the skillsMap generated by this to populate the skillsMap used by grantMissingSkills. Will hopefully have something ready to submit tomorrow.