pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 406 forks source link

Loggerhead Gall Carrier Skill not applying & pyfa error #1321

Closed Wigster30 closed 6 years ago

Wigster30 commented 6 years ago

Hi,

I get the following error when I try and fit a remote shield booster to the new Loggerhead Force Auxiliary. Closed & reopened Pyfa, went to view the fit again & get the same error, trying to remove the fit also results in the same error.

If you open in new tab the fit loads without error, however the skill bonus from Gall Carrier is not applied to the Remote Shield Booster but Cald Carrier is applied, which is incorrect.

https://puu.sh/y7Eiw/3ad45e9c76.png

OS version: Windows-8-6.2.9200 Python: 2.7.10 wxPython: 3.0.2.0 SQLAlchemy: 1.0.5 Logbook: 1.0.0 pyfa version: 1.33.0 Stable - Lifeblood 1.0 pyfa root: C:\Program Files (x86)\pyfa save path: C:\Users****.pyfa fs encoding: mbcs

EXCEPTION: unsupported operand type(s) for *=: 'NoneType' and 'int'

File "C:\Program Files (x86)\pyfa\library.zip\gui\builtinViews\fittingView.py", line 349, in appendItem populate = sFit.appendModule(fitID, itemID) File "C:\Program Files (x86)\pyfa\library.zip\service\fit.py", line 538, in appendModule self.recalc(fit) File "C:\Program Files (x86)\pyfa\library.zip\service\fit.py", line 1212, in recalc fit.calculateModifiedAttributes() File "C:\Program Files (x86)\pyfa\library.zip\eos\saveddata\fit.py", line 790, in calculateModifiedAttributes item.calculateModifiedAttributes(self, runTime, False) File "C:\Program Files (x86)\pyfa\library.zip\eos\saveddata\ship.py", line 102, in calculateModifiedAttributes effect.handler(fit, self, ("ship",)) File "C:\Program Files (x86)\pyfa\library.zip\eos\effects\shipbonusforceauxiliaryc1remoteboostandcapamount.py", line 17, in handler skill="Caldari Carrier") File "C:\Program Files (x86)\pyfa\library.zip\eos\effectHandlerHelpers.py", line 54, in filteredItemBoost element.boostItemAttr(*args, *kwargs) File "C:\Program Files (x86)\pyfa\library.zip\eos\effectHandlerHelpers.py", line 256, in boostItemAttr self.itemModifiedAttributes.boost(args, *kwargs) File "C:\Program Files (x86)\pyfa\library.zip\eos\modifiedAttributeDict.py", line 375, in boost boostFactor = self.__handleSkill(skill)

blitzmann commented 6 years ago

This seems to be a bug in EVE. The ship has the shipBonusForceAuxiliaryC1RemoteBoostAndCapAmount effect. This effect looks for the shipBonusForceAuxiliaryC1 attribute on the ship and uses it to modify Remote Cap Transfer and Remote Shield Boost amount (see Caldari bonus for Minokawa). The Loggerhead, as far as I know, is not supposed to have this bonus. The error happens because this bonus is looking for the shipBonusForceAuxiliaryC1 attribute on the loggerhead, which it doesn't have.

I've reported it to CCP. As a stop-gap, I'll tweak the effect file to avoid this issue.