search

pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.6k stars 407 forks source link

Feature request: More reasonable add charge to cargo #1344

Open Calio-Templar opened 6 years ago

Calio-Templar commented 6 years ago

Current Pyfa offers two options on adding charge to cargo: one, or one thousand. A thousand charges are reasonable for other factions, but not for amarr. One charge is reasonable for none, since all amarr ship has more than two guns.

My request is that adding one charge option would be more reasonable if it becomes add "a clip size of" gun equipped on ship. e.g. 200 for electron blasters, 80 for 200mm autocannon, 1 for all amarr guns. etc.

Calio-Templar commented 6 years ago

clip size = sum of all gun clip. 4 200mm auto should let me add 320 charges.

and if this is possible: 2 200mm + 1 150mm(120 clips) = 280 charges (80 + 80 + 120) 2 electron + 2 200mm = 160 charges from projectile ammo group and 400 charges from hybrid charge group.

would be great, when i mix guns.

ghost commented 6 years ago

Just to confirm I understand:

If I have 5 200mm railguns and I press add charge to cargo it would give 80 5 = 400 If I have 3 200mm railguns and 2 250mm railguns it would give (80 3) + (40 * 2) = 320

I do not believe it would be possible to do different ammo types at the same time as the right click option would be on the charge market item you want to add.

blitzmann commented 6 years ago

I believe there is a feature request already out for "smart charges" that take into consideration the guns you have, clip size, etc. The thought behind it at the time is it will basically pop a dialog that gives you options such as "Fill cargo with x reloads" or something.

I do not believe it would be possible to do different ammo types at the same time as the right click option would be on the charge market item you want to add.

I believe you're correct. I think if you have an Autocannon and Blaster mixed fit, if you select EMP S and add that to the cargo, it would only add it for the supporting guns. We could always expand on this, of course - for example give the gun an option to add supporting ammo to cargo, and you could select multiple ammo types to store (for example, add x reloads of EMP S and Phased Plasma S). But that's a bit more complicated, and I think the original idea is a good stepping stone.

One thing to be cautious about - does this make sense for other charges that aren't ammo. For example, scripts? I don't think it would be problematic, but something to consider.

I don't believe this will be too difficult of a feature to add. @burnsypet, what do you think?

Calio-Templar commented 6 years ago

As I know of, all guns' clip size depends on its charge volume capacity. e. g. 250mm raligun has 1m^3 charge capacity, and since one charge has 0.025m^3 volume, It gives me clip size of 40. The numbers may vary for I am not online at eve now. Doing a couple of division to get its clip size and show it as a recommendation wouldn't be hard I guess. @blitzmann I think scripts work the same way. all scriptable module has 1m^3 charge capacity and all scripts have 1m^3 volume size.

ghost commented 6 years ago

@blitzmann I've been a bit busy this week but can have a stab at this tomorrow.