pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 408 forks source link

Pyfa icon is not shown in linux/wayland session #1607

Open DarkFenX opened 6 years ago

DarkFenX commented 6 years ago

pyfa_icon

It's shown on the same machine under X11.

minlexx commented 6 years ago

Wayland requires properly written *.desktop - file (correct me if I'm wrong) I'm also interested to know what exactly is needed to display icon for app...

blitzmann commented 6 years ago

If it's simply a new file we should include in the root directory, should be easy. Otherwise, ¯_(ツ)_/¯

I guess X11 takes the main window icon to use as default, and wayland doesn't?

minlexx commented 6 years ago

According to https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/ section "Setting window icon":

On X11 the applications exported the window icon as pixmap data. This is no longer possible on Wayland. Instead the compositor maps the window icon from the desktop file and the application announces the desktop file for a window.

For Qt, desktop file name for and application is set by QGuiApplication::setDesktopFileName and is implemented by setting some X11 window property by (probably) code like this - NETWinInfo::setDesktopFileName()

Don't know what the analog for wxWidgets (or wxPython) is, this question might be somewhat related - https://stackoverflow.com/questions/9324163/how-to-set-application-title-in-gnome-shell

There should be a simple way... to set window class or desktop file name implemented in library (wx as high-level api :)

blitzmann commented 6 years ago

I've asked in the wxpython-users group to see if anyone knows of a quick way to solve this.

https://groups.google.com/forum/#!topic/wxpython-users/51ASspXPZs8

DarkFenX commented 6 years ago

Exported icon in X11 looks ugly as hell - it's too low-resolution. Icons are normally 256x256 here in gnome3 if i'm not mistaken. So in any case it's better to have something high-reso shown in this menu.