pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 408 forks source link

needed skill export not working #1636

Open paulheu opened 6 years ago

paulheu commented 6 years ago

Bug Report

issue #1412 seems to have returned "Export Skills Needed" from File menu results in an empty file regardless of chosen export file type

rinakondur commented 6 years ago

Confirming, just selecting the text option yields a file stating Pyfa exported plan for "All 5" but no list of skills needed.

blitzmann commented 6 years ago

Thanks for the report guys, will look into this :)

ghost commented 6 years ago

I'm pretty sure this is working as intended, but perhaps the feature doesn't do what people expect.

The skills exported are all the ones required for the currently active character to fly the ship, so if you're using an all 5 character the list will be empty because it has all of the required skills. If you use an all 0 character then you'll get a list of everything required to operate the ship and it's modules like this:

Pyfa exported plan for "All 0 *"
===============================================================================

-------------------------------------------------------------------------------
Skills required for Retribution:
    Amarr Frigate: 5
        Spaceship Command: 1
    Assault Frigates: 1
        Spaceship Command: 3
        Power Grid Management: 5
        Mechanics: 5
-------------------------------------------------------------------------------
blitzmann commented 6 years ago

Ah, yes, @burnsypet is correct. This is a "what don't I have" export, not a "what should I have".

Basically, if you have a green skillbook next to the character for the fit, you're probably going to get a blank file.' I'm open to discussion on ways to improve this (maybe it should be the other way?) I believe the idea way back when was to be able to import the list into EVEMon, but then again EVEMon is dead, so...

What is the current usecase for this feature?

paulheu commented 6 years ago

The idea would be I can export/create a skill plan for a specific fit which I could share with viewers on stream. Frankly the explanation given makes sense I I can work with this as-is.

blitzmann commented 6 years ago

As an interim, we can probably add a bit of text in the header indicating the listed skills are what the character doesn't have. Or we can switch to including them all, and otherwise marking the skills that aren't learned / up to the level. This issue comes up every now and then, and it's always been kind of a confusing export :/

lunemec commented 3 years ago

This might actually change into feature request: add a option to export skill plan for the ship - the newly introduced skill plans I mean.

blitzmann commented 3 years ago

@lunemec thats a fun idea, but I don't see a way in the UI to import skills into a skill plan. I also don't see anything in ESI.

lunemec commented 3 years ago

@blitzmann I can't check now because it fails for me in game (the window errors out). But CCP plans to have a feature where you can move a fitting into the skill plan to make the skill plan, so maybe this feature is not really that useful if it duplicates in-game feature.

lunemec commented 2 years ago

@blitzmann sorry it took me so long to respond. The in-game skill plan feature is quite simple, you can create skill plan, and paste skills from clipboard in this format:

Hull Upgrades III
Hull Upgrades IV
Hull Upgrades V
Weapon Upgrades III
Weapon Upgrades IV
Electronic Warfare II
Electronic Warfare III
Electronic Warfare IV
Drones II
Drones III
Drones IV
Drones V
Minmatar Drone Specialization I
Advanced Drone Avionics I
Drone Interfacing I
Drone Interfacing II
Drone Interfacing III
Drone Interfacing IV
Missile Launcher Operation II
Missile Launcher Operation III
Missile Launcher Operation IV
Missile Launcher Operation V
Anchoring I
Target Painting I
Sensor Linking I
Energy Pulse Weapons I
Light Missiles I
Light Missiles II
Light Missiles III
Heavy Missiles I
Heavy Missiles II
Heavy Missiles III
Heavy Missiles IV
Cruise Missiles I
Cruise Missiles II
Cruise Missiles III
Cruise Missiles IV
Missile Bombardment I
Missile Bombardment II
Missile Bombardment III
Missile Bombardment IV
Light Drone Operation I
Light Drone Operation II
Light Drone Operation III
Light Drone Operation IV
Light Drone Operation V
Drone Sharpshooting I
Drone Sharpshooting II
Drone Sharpshooting III
Drone Sharpshooting IV
Sentry Drone Interfacing I
Sentry Drone Interfacing II
Sensor Linking II
Sensor Linking III
Sensor Linking IV
Signal Suppression I
Signal Suppression II
Signal Suppression III
Signal Suppression IV
Minmatar Drone Specialization II
Minmatar Drone Specialization III
Missile Projection I
Missile Projection II
Missile Projection III
Missile Projection IV
Rapid Launch I
Rapid Launch II
Rapid Launch III
Rapid Launch IV
Target Navigation Prediction I
Target Navigation Prediction II
Target Navigation Prediction III
Target Navigation Prediction IV
Warhead Upgrades I
Warhead Upgrades II
Warhead Upgrades III
Warhead Upgrades IV
Guided Missile Precision I
Guided Missile Precision II
Guided Missile Precision III
Guided Missile Precision IV

It would be just a matter of changing the text output of the function, and it would be awesome to create skill plans from fits!

lunemec commented 2 years ago

@blitzmann I hacked a quick text export that works with skill plans (I just tested to import it and it works). EVE is even smart enough to sort the skills correctly by the required prerequisites! so no need to do it here.

https://github.com/pyfa-org/Pyfa/pull/2430

lunemec commented 2 years ago

For future reference, it turns out that copy+paste of the skill required always worked in the original format to be pasted ingame and into skill plan too. I just never noticed. Feel free to ignore my previous comments.