pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 406 forks source link

Dummy modifiers #1982

Open fonsui opened 5 years ago

fonsui commented 5 years ago

The ability to apply dummy modifiers to specific stats will significantly help my shipbuilding work. These modifiers can be displayed in a new "Dummy modifiers" tab in the "Additions" area, and toggled on and off at will once added. The individual dummy modifiers can be added in a number of ways, the first of which can be by right-clicking a given stat in the "Affected by" tab of the item/ship stats dialog.

Example: right-clicking "Shield Capacity" allows me to create a dummy modifier for this stat, which then shows up in a tab in the additions area, with a check toggle.

DarkFenX commented 5 years ago

What is "dummy modifier"?

fonsui commented 5 years ago

I would like to be able to apply any effect I choose to the currently open fitting. If I want to simulate 200 GJ/s of incoming neut, I have to build another ship that has 200 GJ/s of neut and project it, and there are some effects that simply cannot be properly simulated in this manner. This applies to beneficial effects as well as harmful effects.

Essentially, as as now we can design custom damage pattern and target resist profiles, or choose between pre-set profiles, I would like to be able to create custom environmental effects and sets of effects, that can utilize any valid stat.

CryoMyst commented 5 years ago

EFT used to have it so you could drag a module from a fit onto another to "project" that effect with the same stats.

DarkFenX commented 5 years ago

Arbitrary effects are completely different to projected modules with frozen stats.

Backend-wise, I think projected modules with frozen stats are much easier to do than "dummy modifiers", but having UI which is sensible for them is nearly impossible in pyfa since you cannot have multiple fits visible.

CryoMyst commented 5 years ago

Having basic effects in the Projected tab would probably work, for example:

Projected (Right click) > Add Custom Effect >Effect Category (Capacitor / Repair / Interdiction) > Effect Type Then have a box come up to specify the strength of said effect

Custom stat abyssal modules could be used to quickly implement this, for example a _x_Gj/s neut could be simulated with a 1second cycle time x neuting amount abyssal neut projected on the fit.