pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.62k stars 409 forks source link

[Implants] Add an ability to add the whole set of implants from market list #2072

Open Gochim opened 5 years ago

Gochim commented 5 years ago

Generally simplify work with implants groups.

Suggestion

Add a full implant set (Snake, Amulet etc) in a couple of clicks from the market list into the Implants tab in the fit window even without creating a dedicated set in an implant set editor.

Expected behavior

Press on an implant in market window - show additional menu item "Add the whole set"

DarkFenX commented 5 years ago

I usually enter something like "mg nomad" into search and then press alt-1 through alt-6 to achieve this.

How would you define sets? and if you have complete list of sets, isn't it better to make multilevel menu in implants tab, like Add Preset Set - Asklepian - High-Grade?

Gochim commented 5 years ago

I usually enter something like "mg nomad" into search and then press alt-1 through alt-6 to achieve this.

Same here :) And that is my point - it's a lot of presses/clicks so something pretty simple. Instead you type "snake", right-click any element of the set, select "Add whole set". Done.

How would you define sets? and if you have complete list of sets, isn't it better to make multilevel menu in implants tab, like Add Preset Set - Asklepian - High-Grade?

It is a possibility. Though I'm not sure about multilevel menu simply because it's, again, more click than it should be.

Another way might be to add all EVE sets as a pyfa implant set by default. And then use the current functionality: in "implants" tab in the fit window select "Add implant set" -> "High-grade snake".

Or maybe do both ways - add ability to add from the market view and add eve sets as by default.

DarkFenX commented 5 years ago

Adding all sets would make the menu too long. I think multi-level menu, a-la ammo picker, is the best approach here. Also it doesn't add extra clicks, just a bit more reading, aiming and mouse movement. Not necessarily more than flat menu btw, especially if it is large enough to become scrollable (which is very likely on gtk and quite likely on mac even with normal ui scaling).

Could do the same for boosters.

If we have that, I see little reason to do it via market view.