pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 409 forks source link

"factor reload" fails in firepower context menu #209

Closed blitzmann closed 9 years ago

blitzmann commented 9 years ago

This is due to the target resists menu overriding the main menu's action upon selection (which is in part due to the entire context menu system being somewhat broken).

Proper fix would be an overhaul of the context menu system (which may be required anyway to support Tactical Dessy Modes, which is what I was working on when this happened). A more comprehensive discussion of why the context menu fails should come soon.

blitzmann commented 9 years ago

Fixed in 892c5c5b60c46302f865369d1952a61c04ffcf9f

Event bindings with multiple submenu's is confusing. But I managed to get it to work by binding individual menu items rather than just telling the menu to use this handler, which didn't seem to ever work right. I adjusted everything except the damage pattern menu to select incoming damage pattern. I am not sure but it just wouldn't work. This is okay for now as I can still just bind then entire menu as that's the only thing the menu is used for, but it will need to be changed if we ever want another context item there.