search

pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 408 forks source link

Do not reduce calibration for offline rigs #2303

Closed ericklaus closed 3 years ago

ericklaus commented 3 years ago

Bug Report

Expected behavior:

When offlining a rig, it continues to consume calibration.

Actual behavior:

When offlining a rig, it no longer consumes calibration.

In Eve, it is not actually possible to offline a rig. But in pyfa, it is allowed so that users can see the effect of the rigs on stats without deleting and adding again. However, removing the rig from the calibration calculation may mislead users into thinking offlining the rig is actually possible in-game. Having the rig continue to consume calibration seems most likely to prevent the user from creating an invalid fit.

Detailed steps to reproduce:

  1. Put a rig on a ship
  2. Offline the rig

The ship's consumed calibration will decrease but it should have remained the same.

Fits involved in EFT format (Edit > To Clipboard > EFT):

n/a

Release or development git branch? Please note the release version or commit hash:

2.33.0

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

Windows 10

ericklaus commented 3 years ago

This is arguably a feature request. I debated whether bug report or feature request was most valid. But it surprised me, so I decided on bug report. :D

EntelligenteEnte commented 3 years ago

In Eve, it is not actually possible to offline a rig.

The simulation mode of the fitting window allows offlining rigs and offlined rigs do not consume calibration.

blitzmann commented 3 years ago

@ericklaus as you noted, pyfa has the ability to offline the rig for reasons regarding the user experience rather than keeping true to the simulation. However, this makes it act like every other module, and so resources that it would normally consume will no longer be consumed when offlined.

I feel like this is a pretty niche feature request, and we would have to make a special case for rigs only to ignore their state in pyfa and always consume calibration resources. I feel we would get more people reporting that as a bug when they go to offline it and notice that the calibration remains.

We appreciate the feedback and I can see where you're coming from, but due to the above, I'm going to close this issue for now. If we get others wanting a similar feature, we can talk more in depth about it. 😀

Thanks!