pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 408 forks source link

Feature Request: Reactive Armor Hardener Override #2349

Open njblackwolf opened 3 years ago

njblackwolf commented 3 years ago

A method of setting the "current" resistances provided by a reactive armor hardener such that, for example, one may evaluate a fit's EHP vs Fusion ammo before the hardener has shifted and the resistances are 15/15/15/15. The present behavior of the reactive armor hardener in Pyfa results in the hardener automatically shifting as appropriate to the damage type and as a result the EHP numbers shown reflect the post-shift EHP.

Ebag333 commented 3 years ago

Already exists, it's a preference to toggle the old behavior on/off (found under the Fitting Engine section)

njblackwolf commented 3 years ago

Hello,

Thank you for your response. However, when using the method you have described, the desired result is not obtained.

For example: I have a fitting which uses the RAH and I would like to know its EHP vs, for example, Fusion, but specifically while the RAH is active and non-shifted 15 / 15 / 15 / 15. I set the incoming damage type to Fusion and the RAH shifts to 0 / 0 / 30 / 30 in both the normal behavior and the "old behavior".

In the options section, the description for the toggle you have described even specifically states, "When the damage profile is Uniform..."

I believe the case I have described here and above is a different usage and it may be beneficial to offer such a functionality. I do not have much UI experience, but I could see adding something under the module-specific right-click menu (perhaps similar to how abyssal mods work) which allows the user to override the reactive behavior with whatever % resists for each damage type they wish to test.

njblackwolf commented 3 years ago

Sadly, it appears that people are not interested in a feature for the above. The workaround, unfortunately, is to create a custom module and hope that you got the properties correct so that Pyfa doesn't give it stacking penalties.

blitzmann commented 3 years ago

@njblackwolf it's not that there isn't any interest, it's that developer time is limited, and the RAH is notoriously confusing to work with. I can absolutely see the reason you may want to know what the EHP is when you first start getting pummeled by Fusion, before the RAH has a chance to adjust, and I don't think that's something we have available at the moment.

I can see few solutions:

I don't have a whole lot of time at my disposal myself (indeed, I've just come back from a 1.5 year hiatus to work on the upcoming SSO changes). But I'm going to reopen this in case anyone else is interested in tackling this. :)