search

pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 408 forks source link

Stop displaying None for units without displayName #2355

Closed gaunts closed 3 years ago

gaunts commented 3 years ago

Closes #2354

I chose to stop displaying None for units without a displayName. An other solution would have been to give a displayName to the "Fitting Slots" unit in dogmaunits.0.json We could also remove "unitID": 122 from dogmaattributes.0.json

gaunts commented 3 years ago

Carefull, I removed a todo: @todo: move this to a more central location, since this is also used in the item mutator panel When I moved FormatValue to gamedata.py. Let me know if you don't agree with the new location of this method

DarkFenX commented 3 years ago

I was forced to do similar change to support drone mutaplasmids (since tracking is a value without unit). But, i did it only for mutations panel, will see how to extend it to attribute view as well. Since your PR is no longer compatible, i will just do changes myself. Sorry for not looking at it before i started updating pyfa.

DarkFenX commented 3 years ago

I think you also got it wrong. You moved it to unit, but as i said, not every attribute has unit.

Anyway, closing, my installation shows that slot attributes have no None suffix, so probably my change fixed it.