pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 408 forks source link

For each Ship Stat show skill diff Pilot vs All_5 #2358

Open Napoleon-BlownApart opened 3 years ago

Napoleon-BlownApart commented 3 years ago

Thanks for this cool tool!

This is a feature request, and the title essentially says it all.

When swapping between my character's skills/implants/boosters and All_5_Skills, I'm seeing some significant differences in the ship's stats which I'm unable to explain (since I'm not familiar with all the dependencies). So I'm wondering if it would be possible, like the detail window that shows "Affected By" for a module, to introduce a visualisation as a tool-tip or sub-menu option, for each stat in the RHS panel (e.g. DPS, Shields, Cap Recharge, etc.).

I have no firm opinion of how the information would be visualised.

Sezoia commented 3 years ago

The main issue im noting appears to be stemming from, what I see, CPU and Powergrid Management V. The 5% implants update their related values correctly, however the base skills do not. I'm unsure whats the root of this issue, but its rather annoying. I cannot confirm any other affected skills.

Sezoia

Napoleon-BlownApart commented 3 years ago

Thanks for taking a look. I wasn't thinking specifically about any particular skill. What I am looking for, is to understand which Skills have impact on which Ship/Module stats, to help me plan my Training Queue.

Sezoia commented 3 years ago

I see. In that case, you want to Right Click and 'change affecting skill'. Ill upload pictures for you to follow. [image: image.png] [image: image.png]

Hope this is what youre looking for. Tosh

On Sun, Oct 3, 2021 at 5:28 AM Napoleon-BlownApart @.***> wrote:

Thanks for taking a look. I wasn't thinking specifically about any particular skill. What I am looking for, is to understand which Skills have impact on which Ship/Module stats, to help me plan my Training Queue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pyfa-org/Pyfa/issues/2358#issuecomment-932931773, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDENWIW6IPDIACPYCAAHR3UFA45JANCNFSM5EJ5NFFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

blitzmann commented 2 years ago

So, the "change affecting skill" context menu is a good start, however it's pretty limited, and there's some situations IIRC where it just doesn't work (missing skills, skills that are technically correctly shown but aren't intuitive as to why they are shown), And it's not intuitive to know which things are affecting a specific ship-wide stat, like CPU. You'd have to look at affected by tab on the ship for CPU output, and affected by tab on modules that increase cpu output or decrease cpu the module uses, etc.

I can totally see some sort of panel that would loop through the fit and find particular attributes related tot hat stat, and give you a summary of what is affecting it. I can see the first iteration being only CPU and Power, as those are always useful to know. Or, maybe a general purpose window that you can select which attributes you want to aggregate data for. Would definitely want to think hard about how to visualize this.