search

pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 408 forks source link

Add Command Burst effect in Miscellanea Column #2360

Closed shyadow closed 2 years ago

shyadow commented 3 years ago

Hi, this PR adds the strength of command bursts in the Miscellanea column. The strength of command bursts was (afaik) not easily available in pyfa. It allows you to more easily compare the strength you get with a certain character to what it would be at max skills, or the strengths of command bursts on different ships

Example: Ingame: image

In pyfa (with this pull request): image

When I run the tests a lot of them fail, but they were already failing when I cloned the repo. I don't think my addition broke anything, but let me know if those tests should be passing.

Also let me know if there's anything else I should change!, it's pretty much my first time doing a pull request to another project :)

blitzmann commented 3 years ago

Looks good to me! I'll wait for @DarkFenX to approve and merge - I'm not sure what's going on with travis / appveyor builds, and no longer familiar with any merge procedures, so I'll wait for him :)

shyadow commented 2 years ago

Any idea when this might be reviewed or added?

DarkFenX commented 2 years ago

I was busy with AT and after it i dealt with work backlog and sisi pyfa updates. Will look into all issues/PRs posted this weekend and next week.

DarkFenX commented 2 years ago

I will merge it, but will do some extra changes (like using pyfa number formatter and change wording in some areas), thanks for it.