pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 408 forks source link

Error fetching skill information #2364

Closed ziggo0 closed 3 years ago

ziggo0 commented 3 years ago

Bug Report: Started occurring yesterday. Hit refresh on a character so their skills were up to date when I was met with the "Error fetching skill information" window. Same thing occurs when adding a character.

Expected behavior: Character is successfully added to 'SSO Character Management' / skills update without error when refreshing them individually.

Actual behavior: "Error fetching skill information" popup window

Detailed steps to reproduce: Open Pyfa, Character -> Manage ESI Characters, Add Character, Authorize through EVE portal, Pyfa pops up error window "Error fetching skill information"

Open Pyfa, Editors -> Character Editor, Select character from drop down -> EVE SSO tab, 'Get Skills' button, popup error window "Error fetching skill information"

Fits involved in EFT format (Edit > To Clipboard > EFT): No fit involved.

Release or development git branch? Please note the release version or commit hash: Release 2.37.0

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10): Windows 10

Other relevant information:

pyfa-2021-10-26.log

I've wiped dns cache, tried no dns blocking (pfblocker-ng), tried public dns, tried my laptop, tried my laptop on my phone's hotspot - same error each time. Nothing has changed with my setup. I've also tried wiping all Pyfa settings and starting from scratch, no change.

Edit: I noticed that it seems the initial pull for character skills works, but not updating after.

blitzmann commented 3 years ago

The log shows an HTTP 404 error. I am assuming that this is due to CCP shutting off the v4 route for character data. This has been fixed in a previous commit b5816a312ca31de781a23bea1183d8131b2ac712 but it has not been released yet.

The next release should be in the next few days according to @DarkFenX, and should also include updates to SSO to keep us ahead of other deprecations by CCP.

Also note the skills should technically update even with this error. Whenever you update skills, it technically does two calls - one for the skills (which should be successful) and one for generic character data (to update sec status)(which is not successful). We process the skill results before calling the next API. So even if you get that error, in this situation, there's a good chance that the skills are being updated.

DarkFenX commented 3 years ago

Fixed in v2.38.0