blitzmann
commented
2 years ago Thanks for going one step further and diving into things, it make it much easier on us.
This is interesting, I would have assumed we would have heard about this long before now, as if it's a timezone issue there's got to be more than 1 person experiencing the issue. I'll try to reproduce this tonight. However, I have a few concerns. python-jose uses datetime.utcnow() which should give you a time that is in UTC (+0) regardless of your local time zone.
eg: I'm in EST (-5). My current local time is 3:35pm (15:35). Running datetime.utcnow() returns 8:35pm (20:34), which is what it currently is in +0. So it should always be returning the UTC time
Are you able to run the following on your computer, just as a sanity check:
from datetime import datetime
print(datetime.utcnow().utctimetuple())
print(datetime.now().timetuple())This should show both local time and utc time.
I also see a thumbs up for this issue by @MoonOfTheWind, are you exhibiting the same issue?
videxerion
I think that disabling the check would help, but I thought that changing someone else's code with handles is not a good idea.
dannyeei
GaelC92
Bug Report
Expected behavior:
Login to ESI.
Actual behavior:
JWT token error, The JWT token has expired: Signature has expired
Detailed steps to reproduce:
1) Open 'PYFA' 2) Open 'Character' 3) Open 'Manage ESI Characters' 4) Click 'Add Character' 5) Enter ESI and get base64 string (Manual method) 6) Get local server startup error
Release or development git branch? Please note the release version or commit hash:
The version was obtained via 'git clone'.
Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):
5.16.2-arch1-1
Other relevant information:
When checking the token, the program considers it 'obsolete', after googling a little, I found out that the 'exp' parameter in the token itself is responsible for this. The check takes place in the 'esiAccess.py' file, 'services' folder.
After a little searching, I realized that you use the 'python-jose' library to work with jwt tokens, by opening its code and finding the decode method, I found the '_validate_exp' method in which the token is checked for 'validity'.
As it turned out, the library developers use the current time zone of my computer (+3:00) and the time specified in the JWT token is in the zone (+0:00), which is why the token is immediately considered 'not valid'.
A quick fix error on the user's side can be corrected by changing the clock, in my case it worked. On the part of the developer, you can refuse to check the token or rewrite everything to a new library for working with tokens, which allows you to specify the time zone when checking the 'exp' parameter. 'Python-jose' and 'PyJWT' don't provide this feature as far as I've been able to find.