search

pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.6k stars 406 forks source link

Python 3.10 compatibility #2406

Closed wereii closed 9 months ago

wereii commented 2 years ago

This fixes problems with wxPython and python310 where C extensions will not silently accept floats as ints in function arguments anymore.

Also see #2391

wereii commented 2 years ago

This is still a big WIP. This PR is there just for tracking.

Phoenix591 commented 2 years ago

well, things have come a good way it seems, on the dep_facelift branch using a patched logbook it seems to be working with python 3.10 now.

wereii commented 2 years ago

@Phoenix591 so the plan is to eventually merge the dep_facelift changes into master, right? I am thinking about switching pyfa on AUR to this branch.

Phoenix591 commented 2 years ago

@Phoenix591 so the plan is to eventually merge the dep_facelift changes into master, right? I am thinking about switching pyfa on AUR to this branch.

Presumably at some point, but I'm just someone who decided to try it

DarkFenX commented 2 years ago

The plan is to have it merged as soon as it's ready.

FYI, even on this branch, some windows still have issues - for example, implant set editor. And i think this issue has to be fixed somewhere on wx side, because all sizes pyfa passes are integer, issue happening there is somewhere deeper down.

DarkFenX commented 9 months ago

Closing this, as dep_facelift branch has had all the needed changes and will be merged to master soon