search

pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.6k stars 406 forks source link

Target Profile Editor Speed and Signature Not Factored #2469

Open pick-a-name-for-fun opened 1 year ago

pick-a-name-for-fun commented 1 year ago

Bug Report

Target Profile Editor speed and signature radius are not factored into the firepower calculation. Changing either one or both resulted in no change to the firepower numbers.

Expected behavior:

Increasing or decreasing either value should modify the firepower calculated for DPS.

Actual behavior:

Nothing happens when the values are changed.

Detailed steps to reproduce:

  1. Open Pyfa
  2. Load the below fit
  3. Create new Target profile in Target Profile Editor with 70/70/70/70 resistances, 185 m/s, and 150m signature.
  4. Change m/s and/or signature to any value and the dps shown under Firepower is not impacted.
  5. I did not test with other fits or target profiles.

Fits involved in EFT format (Edit > To Clipboard > EFT):

[Praxis, Praxis C3 T2 Cruise]

Capacitor Flux Coil II Capacitor Flux Coil II Capacitor Flux Coil II Capacitor Flux Coil II C3-A 'Hivaa Saitsuo' Ballistic Control System C3-A 'Hivaa Saitsuo' Ballistic Control System 'Dyad' Co-Processor I

X-Large Shield Booster II Multispectrum Shield Hardener II Multispectrum Shield Hardener II Multispectrum Shield Hardener II Eutectic Compact Cap Recharger Shield Boost Amplifier II Shield Boost Amplifier II

[Empty High slot] Cruise Missile Launcher II, Mjolnir Fury Cruise Missile Cruise Missile Launcher II, Mjolnir Fury Cruise Missile Cruise Missile Launcher II, Mjolnir Fury Cruise Missile Cruise Missile Launcher II, Mjolnir Fury Cruise Missile Cruise Missile Launcher II, Mjolnir Fury Cruise Missile Cruise Missile Launcher II, Mjolnir Fury Cruise Missile

Large Capacitor Control Circuit II Large Processor Overclocking Unit I Large Capacitor Control Circuit I

Hammerhead II x5 Hobgoblin II x8 Hornet EC-300 x5 Ogre II x4

Mjolnir Fury Cruise Missile x10000 Mjolnir Precision Cruise Missile x10000 Missile Precision Script x1 Sisters Core Scanner Probe x8

Release or development git branch? Please note the release version or commit hash:

Release 2.46.0 Eve Data Version 2123216 (2022-09-29 04:51:36)

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

Windows 10 21H2

Other relevant information:

DarkFenX commented 1 year ago

Target Profile Editor speed and signature radius are not factored into the firepower calculation

This is kind of by design. They are considered only by the graph window. I added signature, speed and radius to target profiles when I refactored graphs.

As for firepower stats window - there is no clean & easy way to add it. To adjust the number for weapons like turrets, you need to know movement vectors, and distance between the attacker and the target. Graphs window allows you to control that, stats window does not.

pick-a-name-for-fun commented 1 year ago

Understood, thank you. I'll start working there.

With the missile fit I naively assumed the 4 variables would show up in damage since it's a more basic calculation.

On Sat, Oct 22, 2022, 20:39 Anton Vorobyov @.***> wrote:

Target Profile Editor speed and signature radius are not factored into the firepower calculation

They are considered only by the graph window. I added signature, speed and radius to target profiles when I refactored graphs.

As for firepower stats window - there is no clean & easy way to add it. To adjust the number for weapons like turrets, you need to know movement vectors, and distance between the attacker and the target. Graphs window allows you to control that, stats window does not.

— Reply to this email directly, view it on GitHub https://github.com/pyfa-org/Pyfa/issues/2469#issuecomment-1287994989, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3T2N7RUKABES7LVQZ3TIRTWESXO7ANCNFSM6AAAAAARFTWPL4 . You are receiving this because you authored the thread.Message ID: @.***>