pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.6k stars 402 forks source link

Loki Defensive - Covert Reconfiguration overheating bonus is not applied #2484

Closed beedogcc closed 1 year ago

beedogcc commented 1 year ago

Bug Report

As title.

Expected behavior:

The subsystem's overheating bonus should also be applied to Overload Shield Boost Bonus.

Actual behavior:

The bonus is not applied when setting a shield booster to overheat.

Detailed steps to reproduce:

Fits involved in EFT format (Edit > To Clipboard > EFT):

[Loki, Loki fit]

[Empty Low slot]

Dread Guristas Large Shield Booster [Empty Med slot]

[Empty High slot]

[Empty Rig slot] [Empty Rig slot] [Empty Rig slot]

Loki Defensive - Covert Reconfiguration [Empty Subsystem slot] [Empty Subsystem slot] [Empty Subsystem slot]

And for comparison, a Tengu fit where the bonus is applied properly: [Tengu, Tengu fit]

Dread Guristas Large Shield Booster [Empty Med slot] [Empty Med slot]

[Empty High slot]

[Empty Rig slot] [Empty Rig slot] [Empty Rig slot]

Tengu Defensive - Covert Reconfiguration [Empty Subsystem slot] [Empty Subsystem slot] [Empty Subsystem slot]

Release or development git branch? Please note the release version or commit hash:

Release 2.48.0

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

Windows 10

Other relevant information:

N/A

image image

DarkFenX commented 1 year ago

Thanks. Fixed in dd93f348e61057ca7c224c62573280b257fa82fc