pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.59k stars 402 forks source link

Help request: progress bars (i.e. HTML export) crash pyfa on windows #2552

Closed DarkFenX closed 4 months ago

DarkFenX commented 7 months ago

Recently pyfa updated wx from 4.0.x version to 4.2.1. With the upgrade, there was a report about export to HTML crashing:

pyfa v2.57.1+2-gb7a5b33ff
EVE Data Version: 2443636 (2023-12-05 19:37:07)

OS version: Windows-10-10.0.19045-SP0
Python version: 3.11.6 (tags/v3.11.6:8b6ee5b, Oct 2 2023, 14:57:12) [MSC v.1935 64 bit (AMD64)]
wxPython version: 4.2.1 (wxWidgets 3.2.2.1)
SQLAlchemy version: 1.4.50
Logbook version: 1.7.0.post0
Requests version: 2.31.0
Dateutil version: 2.8.2

####################

Traceback (most recent call last):
File "gui\mainFrame.py", line 914, in exportHtml
wx._core.wxAssertionError: C++ assertion ""IsRunning()"" failed at ....\src\common\evtloopcmn.cpp(92) in wxEventLoopBase::Exit(): Use ScheduleExit() on not running loop

Turns out, it was an issue I reported a while ago, back when I still had access to a windows machine: https://github.com/wxWidgets/Phoenix/issues/1610

It should affect export to HTML, backup to XML, import from file (i.e. anything which makes use of wx.ProgressDialog()). I think it'd be nice to have it fixed. But, since I don't have access to windows machine (and I don't entirely trust wine to replicate windows behavior), I need help - someone needs to follow instructions from the ticket, find solution which works (there were at least 2 listed), and create a pull request. I might get to it, but much much later.

DarkFenX commented 4 months ago

Fixed in 907da343b164a0b71644ce2026dcf6321aa5614c