search

pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.61k stars 406 forks source link

When using Color Slot mode, the colors do not connect naturally. #2554

Closed winter0729 closed 10 months ago

winter0729 commented 10 months ago

Bug Report

When using Colot Slot, the colors do not connect naturally, and the color breaks for each column.

Expected behavior:

Colors should be naturally connected. This worked correctly in version 2.56.0. image

Actual behavior:

The color breaks for each column. Starting with version 2.57.0, the following symptoms occur

image

Detailed steps to reproduce:

Edit-> Prefs-> turn on color fitting view by slot (from above 2.57.0 or later.)

Fits involved in EFT format (Edit > To Clipboard > EFT):

Release or development git branch? Please note the release version or commit hash:

Release b5e77415cfd0e873eb4e44ae3ca6ef349f4ef304 0dc2632fc41efae726e22352a9a65e736a6b0c5f

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

Windows 11

Other relevant information:

DarkFenX commented 10 months ago

On linux, they do connect. I will look into possible reasons (we won't revert to older wx, but possibly newer wx exposes a way to control it), but ultimately someone with windows will have to check and/or debug.

DarkFenX commented 10 months ago

This is what pyfa is using for fitting view: https://docs.wxpython.org/wx.ListCtrl.html (with style wx.LC_REPORT).

edit: ok apparently it's one of wx things which I considered a problem earlier, and there might be a solution: https://github.com/wxWidgets/Phoenix/issues/1609

DarkFenX commented 10 months ago

@winter0729 https://ci.appveyor.com/project/pyfa-org/pyfa/builds/48717843/job/in8ux3r2l71ne6wy/artifacts try this build

winter0729 commented 10 months ago

It works, Thank you. image

DarkFenX commented 10 months ago

Cool. Will be included in the next release