Update the SSO Login for Serenity and Singularity server's player

huangzheng2016 commented 4 months ago

The new one fix some problem Another Pr https://github.com/pyfa-org/Pyfa/pull/2437 It was closed by me because of an error in committing the readme.

DarkFenX commented 4 months ago

I am still yet to thoroughly look through the code. Preliminarily I have very few questions:

ali-esi.evepc.163.com - is it actual serenity ESI address, or is it some proxy to it?
I don't remember ESI auth flow well enough, so I don't remember if any kind of sensitive data is exposed to callback page hoster. Who is hoster of https://ali-esi.evepc.163.com/ui/oauth2-redirect.html ?

Later I will refresh how auth is handled. I want to do 2 things before next release: one bug related to progress dialog on windows and this merge request. so unless there are any issues with it, I plan to have it done next few days.

huangzheng2016 commented 4 months ago

It is the actual serenity ESI address, owned by NetEase (the game company that run an agent serenity for Eve Online in China). No data is exposed to the callback page. If you need to test, you can contact me by email to provide the corresponding test account (or you can register one yourself)

DarkFenX commented 4 months ago

No, I don't want to test (if it works for you - it's good for me already), I just don't want keys sensitive to players funneled through third parties.

pyfa-org / Pyfa

Update the SSO Login for Serenity and Singularity server's player #2590