pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.59k stars 403 forks source link

Graph window is broken on MacOS 11.7.10 #2591

Closed JohnnyFonseca closed 4 months ago

JohnnyFonseca commented 4 months ago

the graph window isnt showing properly on Mac OS (11.7.10) as you can see below. the fields for personalizing it are too small

Captura de Tela 2024-02-22 às 19 33 14

DarkFenX commented 4 months ago

Seems like an wxpython issue: https://github.com/wxWidgets/Phoenix/issues/2319

DarkFenX commented 4 months ago

Tbh this issue should be pretty wide-spread. Can you take a look at how input fields of windows like "split drone stack" context menu look? This is how it looks for me:

image

JohnnyFonseca commented 4 months ago

The split drones looks fine! I'll check other places too

Captura de Tela 2024-02-25 às 21 22 20

Edit: Yeah set distance and other popups like the "split drones" one are fine!

DarkFenX commented 4 months ago

Windows where issue might happen:

I did not check context around uses of wx.TextCtrl in those parts, so maybe size is set somehow and that's why they work. But would be nice to check all of them and see if it's only graphs which needs some workarounds, or more ctrls.

JohnnyFonseca commented 4 months ago

Graph input boxes seems to be the only ones that are broken.

Windows where issue might happen:

  • SSO login (manual method, where you have to paste key manually, needs to be turned on in preferences) Captura de Tela 2024-02-25 às 23 12 59

  • Notes tab in Additions panel Captura de Tela 2024-02-25 às 23 14 34

  • Split drones context menu Sent on post above

  • Save implant set context menu Captura de Tela 2024-02-25 às 23 15 57

  • Change item amount context menu (drones, cargo) Captura de Tela 2024-02-25 às 23 16 37

  • Projected item range context menu Captura de Tela 2024-02-25 às 23 17 44

  • Market window search box Captura de Tela 2024-02-25 às 23 18 24

  • Preferences (database section, logging section, network section) Fine but the colors are hard to read

Captura de Tela 2024-02-25 às 23 19 48

  • Graph input boxes

Captura de Tela 2024-02-25 às 23 20 58

DarkFenX commented 4 months ago

Added an attempt to fix it in 526695fa9ad7af89055ddb28d6536ca069320e39, but I've taken size of those boxes on linux, so idk how big/small that'd be on macos

DarkFenX commented 4 months ago

@JohnnyFonseca https://ci.appveyor.com/project/pyfa-org/pyfa/builds/49274843/job/10stecwndby9i7gj/artifacts try this build and lmk if it looks ok

JohnnyFonseca commented 4 months ago

now its looking Great!

Captura de Tela 2024-02-26 às 16 24 20

JohnnyFonseca commented 4 months ago

the Mkt window is looking very good too after the color fix:

Captura de Tela 2024-02-26 às 16 26 55

DarkFenX commented 4 months ago

Ok good, I have only 1 merge request to check and I will make a new release. Closing this one

JohnnyFonseca commented 1 month ago

I've found another window with the tex box size issue.

its the one for customizing a damage pattern:

Screenshot 2024-05-08 at 18 55 00