pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.59k stars 403 forks source link

Boosts not applying properly, both projected and on boosting fit #2622

Closed kriskog closed 1 day ago

kriskog commented 2 weeks ago

Bug Report

When projecting a fit with command bursts onto another fit, the recipient fit does not receive the boost effects. The boosting ship seems to apply some effects to itself, but not all. In the below example fit, shield applies the resistances but the skirmish does not apply the speed.

Expected behavior:

Command burst bonuses from projected booster fit applied to recipient fit.

Actual behavior:

Nothing or partial effect is applied to recipient fit.

Detailed steps to reproduce:

Open "Boost tester 1". Projected tab, add fit "Boost tester 2". Turn on and off the projected effect to see changes, nothing should change.

Fits involved in EFT format (Edit > To Clipboard > EFT):

[Rifter, Boost tester 1]

[Empty Low slot] [Empty Low slot] [Empty Low slot] [Empty Low slot]

[Empty Med slot] [Empty Med slot] [Empty Med slot]

[Empty High slot] [Empty High slot] [Empty High slot]

[Empty Rig slot] [Empty Rig slot] [Empty Rig slot]

[Bifrost, Boost tester 2]

[Empty Low slot] [Empty Low slot] [Empty Low slot]

[Empty Med slot] [Empty Med slot] [Empty Med slot] [Empty Med slot] [Empty Med slot]

Skirmish Command Burst II, Rapid Deployment Charge Shield Command Burst II, Shield Harmonizing Charge [Empty High slot] [Empty High slot] [Empty High slot] [Empty High slot]

Small Command Processor I [Empty Rig slot]

Release or development git branch? Please note the release version or commit hash:

Release v2.59.2

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

Windows 10

Other relevant information:

Attempted fresh install on different computer, same result.

kriskog commented 1 day ago

Im a dumbass and were adding command ships under projected instead of the command tab 🤡