pyfa-org / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
1.6k stars 403 forks source link

Citadel fitting: Projected effects tab disabled while effects can be projected #707

Closed zhabry closed 7 years ago

zhabry commented 7 years ago

When fitting a Citadel, one can choose to project various effects onto it (Neuts and Damps have very much noticeable effect). Sadly, there's no way to cancel that, as Projected tab is disabled for Citadels. I must admit I have no idea whether you can activate Neuts or E-war on a Citadel in-game or not :)

zhabry commented 7 years ago

Apparently, me playing with aforementioned stuff resulted in some kind data corruption. A Fortizar fit does not show anything on it, not even slots, and cannot be deleted. Opening any ship or citadel fitting and then switching back to that Fortizar (same tab or different tabs) results in right pane (Resources, Resistances, etc.) not refreshing. ss 2016-08-27 at 06 05 01

blitzmann commented 7 years ago

Hmm I thought I checked for this use case... I will take a look and release a point release with a fix. Thanks

On Aug 27, 2016 12:06 AM, "zhabry" notifications@github.com wrote:

Apparently, me playing with aforementioned stuff resulted in some kind data corruption. A Fortizar fit does not show anything on it, not even slots, and cannot be deleted. Opening any ship or citadel fitting and then switching back to that Fortizar (same tab or different tabs) results in right pane (Resources, Resistances, etc.) not refreshing.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

graywolf commented 7 years ago

having same issue, even didn't have to play with anything. just launched pyfa and opened astrahus fitting. Also, after alt-tabbing into eve and back it looks like this http://imgur.com/a/aodMG , almost like the part of the window where the fitting is supposed to be isn't responding to redraw event at all.

blitzmann commented 7 years ago

@zhabry, @graywolf can you please email me at sable.blitzmann@gmail.com and attach your saveddata.db file found in %userprofile%/.pyfa/

I cannot get mine to crash like that. =/

graywolf commented 7 years ago

done, hope it helps :)

blitzmann commented 7 years ago

I still can reproduce the crash causing the fitting window to not work. @graywolf when I open your citadel fit, it opens fine...

Can you give me a specific step-by-step reproduction?

graywolf commented 7 years ago

Sure I can :) Assuming you are using my save file, the Astrahus fitting should be preselected when opening pyfa. So the repo steps are:

1) Open PyFa

even when I delete it and start over, the steps are only slightly longer:

1) Open PyFa
2) Create new Astrahus fitting <-- already I don't see any slots, just blank panel

I supposed more info could help too:

Version: v1.23.0
Installed by: .exe file ( https://github.com/pyfa-org/Pyfa/releases/download/v1.23.0/pyfa-1.23.0-yc.118.7-1.4-win.exe )
OS: Windows 7 (Ultimate N)
Arch: amd64

Can I somehow enable more logging? Or is there log file I can send to you?

PS: I know I'm not of much help, I myself hate when I get bug report saying "it's not working" but that's basically all I know... it's just not working

blitzmann commented 7 years ago

yeah... the citadel fitting is showing fine for me...

There is a log, but it's not very good and usually doesn't work... %userprofile%\.pyfa\log.txt go ahead and post that if there's anything in there

graywolf commented 7 years ago

yeah nothing useful in there :/

hm, I'll try nuking PyFa and reinstalling, maybe will help

zhabry commented 7 years ago

Sent

blitzmann commented 7 years ago

Thanks. I'll take a look at yours this week, but from what you've said in the email it seems that it's difficult to reproduce as well.

Regardless, I have a fix ready for the issue of projections on citadels, which will also remove any that users have applied. If nothing comes from testing on both your DB and @graywolf, then I will release the point release and have you guys test to see if that helps any...

@graywolf I did notice in your database that the citadel in question did not have any projected modules applied, is that correct? So your issue may be completely separate from this one. Again, after th epoint release, if you notice anything, open another issue with a description. :)

blitzmann commented 7 years ago

Update: Do you guys have colored slots enabled in your preferences? #711 was just filed, and I'm thinking that the fitting view is crashing due to that.

update: can confirm crash reproduction: image

Should be an easy fix then :D

zhabry commented 7 years ago

Disabled here: ss 2016-08-30 at 07 36 49

blitzmann commented 7 years ago

I'm going to release the point release tomorrow probably, which will include a fix for this. I implore you guys to give it a try once it releases and let me know if any other issues pop up.

Also, the point release should automatically remove the projected modules from the fits with a migration script. If for some reason that doesn't work, simply recreate the fit from scratch. :)

zhabry commented 7 years ago

Confirming that 1.23.1 fixed bugged Citadel fits for me.