search

pyfar / gallery

Creative Commons Attribution 4.0 International
2 stars 1 forks source link

Add a notebook that shows a basic binaural synthesis #24

Closed pingelit closed 6 months ago

pingelit commented 7 months ago

Open questions:

mberz commented 7 months ago

Please refer to nbsphinx's docs section on how to use interactive widgets in nbsphinx. https://nbsphinx.readthedocs.io/en/0.9.3/code-cells.html#Interactive-Widgets-(HTML-only)

mberz commented 7 months ago

On the issue, that the tests are failing on CircleCI: Please run

pytest --nbmake docs/gallery/interactive/*.ipynb

locally and check what is causing the issue. On my machine it seems that the interpreter is "stuck" somewhere and does not continue, maybe pausing and waiting for user interaction or similar.

mberz commented 7 months ago

The nbmake issue seems to be unrelated to, but caused by something else...

mberz commented 7 months ago

Please merge the most recent state of the main branch for a workaround to the issue.

pingelit commented 7 months ago

Please refer to nbsphinx's docs section on how to use interactive widgets in nbsphinx. https://nbsphinx.readthedocs.io/en/0.9.3/code-cells.html#Interactive-Widgets-(HTML-only)

The problem is the interactive_output. I guess this is too complicated for a pre-rendered html document. I will keep the example commented out. We could add a comment saying that this would have to be run in binder?

pingelit commented 7 months ago

Thanks for the review!

mberz commented 7 months ago

I've implemented a hot fix for the scaling of the scatter plot within pyfar, so we can get rid of the manual axis scaling in the future.

https://github.com/pyfar/pyfar/pull/554

pingelit commented 7 months ago

Thanks for the reviews. I think I got most things now.

pingelit commented 7 months ago

Regarding the plots with the source positions, sikersten and I decided to remove the styling and rather wait for the fix in pyfar.