Adjust `Code` to match the actual browsers

pyfisch / keyboard-types

Types to define keyboard related events.

Apache License 2.0

54 stars 9 forks source link

Adjust `Code` to match the actual browsers #15

Closed CryZe closed 2 years ago

CryZe commented 2 years ago

This adds the missing F13 - F24 values, adds aliases for various values that are still used in Firefox and Safari and adds some values that are only used by Chromium.

Resolves #12 Resolves #13 Resolves #14

pyfisch commented 2 years ago

Hi @CryZe I'll review the code shortly. Thanks for your patience.

CryZe commented 2 years ago

I addressed the review comments and also fixed the regex. Apparently they published new versions of both specs and added a new Required column that the regex couldn't handle.

CryZe commented 2 years ago

Thank you 🎉. Can you potentially release a 0.6.2 for this? I'd like to integrate these changes into druid which has a lot of TODOs regarding missing keycodes.

pyfisch commented 2 years ago

Yes, already done. :smile: