search

pyfisch / keyboard-types

Types to define keyboard related events.
Apache License 2.0
54 stars 9 forks source link

Release v0.7 #35

Closed pyfisch closed 1 year ago

pyfisch commented 1 year ago

There is a number of commits since the last release https://github.com/pyfisch/keyboard-types/compare/v0.6.2...main, mainly modernizing the code and CI to conform to best practices.

@waywardmonkeys Thank you for updating the repository. Do you want to make more changes before the next release?

@madsmtm In #19 you outline the needs of winit. What are the current plans for integrating this crate into winit and which changes should be in the next release?

waywardmonkeys commented 1 year ago

I think the update to 2021 edition … I think everything I wanted for glazier is in now.

waywardmonkeys commented 1 year ago

I will ask in the linebender group if they have anything else

DJMcNab commented 1 year ago

In future, I (for glazier) would like to avoid allocating for our KeyEvent handling. That is not trivial with Key::Character being a String (rather than, say, a Cow<'a, str>).

However, the exact shape of this isn't clear, and has already been discussed quite heavily elsewhere. It also doesn't block us, it's entirely a nice-to-have, so isn't a consideration for v0.7. Additionally, I've not measured the performance/memory impact, which is likely negligible.

We are also aware that it is possible to just reuse the same String in most cases cases, by only passing a & reference, so we may end up just using that strategy

waywardmonkeys commented 1 year ago

I think the update to 2021 edition

This is submitted now: #37

pyfisch commented 1 year ago

Done #39.