search

pyfoo / python-twitter

Automatically exported from code.google.com/p/python-twitter
Apache License 2.0
0 stars 0 forks source link

support GetFavorites #60

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The attached patch implements GetFavorites for the authenticated user, or for a 
given screenname.  
It also refactors the common behavior involved in retrieving a list of Status 
objects from a JSON URL 
into a single method, _StatusesFromJSONUrl (the body of that method was 
repeated four times, and 
my enhancement would have added a fifth.)

Original issue reported on code.google.com by joegermu...@gmail.com on 1 Apr 2009 at 5:04

Attachments:

GoogleCodeExporter commented 9 years ago 
Sorry, I'm not seeing where to mark this as an enhancement instead of a defect, 
but obviously that's what it is.

Original comment by joegermu...@gmail.com on 1 Apr 2009 at 5:05

GoogleCodeExporter commented 9 years ago 
I'd say that a functionality that the Twitter API exposes that is missing in
python-twitter is a defect.

Original comment by dclinton on 1 Apr 2009 at 6:00

GoogleCodeExporter commented 9 years ago 
The attached patch is a diff against r174 which has GetFavorites, GetMentions,
GetFollowerIds and GetFriendIds (see also #63).  I left out the other 
refactoring to
reduce duplication of the various fetch-url-and-process-JSON code because it 
made
diffing too hard.  But I think it would be good to have less wholesale 
duplication in
this code and I will gladly resubmit a patch for that if it will get applied.

Original comment by joegermu...@gmail.com on 7 Jul 2009 at 2:09

Attachments:

GoogleCodeExporter commented 9 years ago 
Applied the GetFavorites and GetMentions portion of this patch as changeset

http://code.google.com/p/python-twitter/source/detail?r=108198df1bd9706a1deec6f6
dcf53ca38bcb2e2a

GetFollowerIds and GetFriendIds were already present from a prior changeset

Original comment by bear42 on 17 May 2010 at 5:11