search

pyfsi / coconut

Coupling Code for Numerical Tools. The documentation can be found at
https://pyfsi.github.io/coconut/
GNU General Public License v3.0
29 stars 4 forks source link

Restructuring of tube examples #71

Closed toondm closed 3 years ago

toondm commented 3 years ago

The number of tube example cases is becoming quite high, as we have combinations of Python solvers, Fluent, OpenFOAM, Abaqus, Kratos, 2D and 3D. That means that e.g. the setup for the Fluent 2D case is saved several times, in different folders. Perhaps we could think of a more efficient way to organize this single example, where each solver wrapper has only one set of setup files, and many different combinations are possible, based on e.g. a folder of JSON files. Something to discuss after the new datastructure has been merged?

navaneethkn commented 3 years ago

I think it is a very good idea. We can put all the solver-specific input files in "tube_example_setup/$solver".

toondm commented 3 years ago

When we restructure the tube example, we should also restructure the documentation about it, and more generally the documentation of the examples in general.

awbral commented 3 years ago

I suggest following restructuring (basically what Nicolas suggested earlier): one folder containing all the case setups. The actual example folders then only contain the JSON files and the setup_< solver >.sh scripts. I will adapt the latter so that the user doesn't have to copy the case setup folders to the main directory of each example.

A question I have now: is it strictly necessary to keep the prefix "tube_" in the name of the example folders? Or are there plans to create other examples with different geometries as well in the future?

nicolasdlss commented 3 years ago

The prefix tube was indeed intended to make the distinction with other test cases. There is another issue about adding a new test case. So I would say yes...

Have you thought about run_simulation.py? This will probably also be copied. And just an idea, maybe we could combine the setup_< solver >.sh scripts to one setup.sh script for each example?