search

pyg-team / pytorch-frame

Tabular Deep Learning Library for PyTorch
https://pytorch-frame.readthedocs.io
MIT License
505 stars 53 forks source link

Fixing Bug in Version Handling. #410

Closed drivanov closed 3 months ago

drivanov commented 3 months ago

I've noticed that the tests with the withPackage test decorators

@withPackage("torch>=2.1.0")
def test_some_test(...):
    . . .

are not being executed, even though I have torch=2.4.0 installed on my machine.

nn/models/test_compile.py::test_compile_graph_break[FTTransformer] SKIPPED (Package(s) {'torch>=2.1.0'} are not installed)

To be precise, I am using Torch version 2.4.0a0+f70bd71a48.nv24.06 which has an unexpected version ID format for the for pytorch-frame .

The proposed PR uses standard Python version handling, which covers the dev case previously treated separately.