pyg-team / pytorch_geometric

Graph Neural Network Library for PyTorch
https://pyg.org
MIT License
21.08k stars 3.63k forks source link

Plan to add an e3nn model #1857

Open mariogeiger opened 3 years ago

mariogeiger commented 3 years ago

🚀 Feature

Dear @rusty1s, What do you think about adding a Model similar to Schnet that has equivariance using higher dimensional representations. To do so I extracted the essential part of e3nn into this repo and copied your implementation of Schnet and changed that architecture with mine.

Motivation

Adding our equivariant model and part of its framework to your nice framework.

Additional context

rusty1s commented 3 years ago

That sounds like a great contribution. Thanks you very much in advance.

I'm definitely open to integrating. As far as I can see, the amount of dependencies is manageable. One could even think of making some of the dependencies optional (like we do in DimeNet).

On the other hand, there are a lot of utility files/functions. Currently, I'm not sure how to handle those properly. Dependent on how specific those are, one could imagine including them in torch_geometric.nn.models.e3nn or in torch_geometric.utils.e3. WDYT?

As an alternative, I see that e3nn is installable via pip. It might be an option to require people to install this package, while having access to a simple model and example in PyTorch Geometric.