pyg-team / pytorch_geometric

Graph Neural Network Library for PyTorch
https://pyg.org
MIT License
21.09k stars 3.63k forks source link

Consolidate Explain test fixtures #6186

Open avgupta456 opened 1 year ago

avgupta456 commented 1 year ago

🛠 Proposed Refactor

Each test file in test/explain has it's own data fixtures and prediction model definitions. This results in a lot of duplication and increased potential for mistakes.

Suggest a potential alternative/fix

From @wsad1: Lets move these to a conftest.py and share across all tests (https://docs.pytest.org/en/6.2.x/fixture.html#scope-sharing-fixtures-across-classes-modules-packages-or-session).

First brought up in #6091

rusty1s commented 1 year ago

Yes, I like this idea.