pyg-team / pytorch_geometric

Graph Neural Network Library for PyTorch
https://pyg.org
MIT License
21.23k stars 3.64k forks source link

GCNConv: Weighted Self-Loops, Gaussian Initialization #7985

Open GageDeZoort opened 1 year ago

GageDeZoort commented 1 year ago

🚀 The feature, motivation and pitch

I'd like to propose the implementation of a new GCNConv using recommendations from this paper:

Principles for Initialization and Architecture Selection in Graph Neural Networks with ReLU Activations The relevant modifications include:

In summary, this would simply generalize the GCNConv to include hyperparameters C_w and t.

Alternatives

No response

Additional context

No response

rusty1s commented 1 year ago

This sounds cool :) We can either add this to the original GCNConv layer or in a separate module that inherits from it. What do you think?

GageDeZoort commented 1 year ago

Thanks for the response, Matthias :) I think it'd be nice to have t and C_W as options in the original GCNConv layer. I'd be fine with having a separate module, though - this is only a loose preference. Either way, I'm happy to help with any implementation or surrounding documentation!

rusty1s commented 1 year ago

Super. Would it be possible for you to provide the initial implementation directly in GCNConv, and I can take it from there?

GageDeZoort commented 1 year ago

Sure, I'm happy to - will open a PR in the next few days!