Closed beew closed 11 months ago
I am not so sure about the GraphMaskExplainer
test failures, but the neighbor loader tests should work if you upgrade to pyg-lib
nightly.
I am not so sure about the
GraphMaskExplainer
test failures, but the neighbor loader tests should work if you upgrade topyg-lib
nightly.
Upgrade to pyg-lib nightly still a lot of failed tests
============================================================================================= short test summary info =============================================================================================
FAILED test/data/lightning/test_datamodule.py::test_lightning_hetero_link_data_custom_store - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_cache.py::test_cached_loader[device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_cache.py::test_cached_loader_transform[device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_imbalanced_sampler.py::test_neighbor_loader_with_imbalanced_sampler - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_imbalanced_sampler.py::test_hetero_neighbor_loader_with_imbalanced_sampler - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[None-None-directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[None-None-bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[None-1.0-directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[None-1.0-bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[True-None-directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[True-None-bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[True-1.0-directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[True-1.0-bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[False-None-directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[False-None-bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[False-1.0-directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_basic[False-1.0-bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_basic[None-directional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_basic[None-bidirectional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_basic[1.0-directional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_basic[1.0-bidirectional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_loop[directional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_loop[bidirectional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_link_neighbor_loader_edge_label - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_temporal_homo_link_neighbor_loader[1] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_temporal_hetero_link_neighbor_loader - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_custom_hetero_link_neighbor_loader - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_no_edges - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_no_edges - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_triplet[1-False-False] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_triplet[1-False-True] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_triplet[1-True-True] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_triplet[2-False-False] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_triplet[2-False-True] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_homo_link_neighbor_loader_triplet[2-True-True] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_triplet[1-False-False] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_triplet[1-False-True] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_triplet[1-True-True] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_triplet[2-False-False] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_triplet[2-False-True] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_hetero_link_neighbor_loader_triplet[2-True-True] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_link_neighbor_loader.py::test_link_neighbor_loader_mapping - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[None-dtype0-SubgraphType.directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[None-dtype0-SubgraphType.bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[None-dtype1-SubgraphType.directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[None-dtype1-SubgraphType.bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[True-dtype0-SubgraphType.directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[True-dtype0-SubgraphType.bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[True-dtype1-SubgraphType.directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[True-dtype1-SubgraphType.bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[False-dtype0-SubgraphType.directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[False-dtype0-SubgraphType.bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[False-dtype1-SubgraphType.directional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_basic[False-dtype1-SubgraphType.bidirectional-device0] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_hetero_neighbor_loader_basic[dtype0-SubgraphType.directional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_hetero_neighbor_loader_basic[dtype0-SubgraphType.bidirectional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_hetero_neighbor_loader_basic[dtype1-SubgraphType.directional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_hetero_neighbor_loader_basic[dtype1-SubgraphType.bidirectional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_on_cora[SubgraphType.directional] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_on_cora[SubgraphType.bidirectional] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_hetero_neighbor_loader_on_cora[SubgraphType.directional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_hetero_neighbor_loader_on_cora[SubgraphType.bidirectional] - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_temporal_hetero_neighbor_loader_on_cora - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_custom_neighbor_loader - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_temporal_custom_neighbor_loader_on_cora - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_pyg_lib_and_torch_sparse_homo_equality - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_pyg_lib_and_torch_sparse_hetero_equality - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_memmap_neighbor_loader - RuntimeError: Caught RuntimeError in DataLoader worker process 0.
FAILED test/loader/test_neighbor_loader.py::test_homo_neighbor_loader_sampled_info - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_hetero_neighbor_loader_sampled_info - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_neighbor_loader_mapping - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_weighted_homo_neighbor_loader - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_neighbor_loader.py::test_weighted_hetero_neighbor_loader - RuntimeError: pyg::hetero_neighbor_sample() Expected a value of type 'Optional[Dict[str, Tensor]]' for argument 'edge_weight_dict' but instead found type 'bool'.
FAILED test/loader/test_utils.py::test_index_select_out_of_range - RuntimeError: INDICES element is out of DATA bounds, id=3 axis_dim=3
FAILED test/loader/test_zip_loader.py::test_zip_loader[True] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/loader/test_zip_loader.py::test_zip_loader[False] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/nn/conv/test_pna_conv.py::test_pna_conv_get_degree_histogram_neighbor_loader - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/nn/models/test_basic_gnn.py::test_basic_gnn_inference[None] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/nn/models/test_basic_gnn.py::test_basic_gnn_inference[last] - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/nn/models/test_basic_gnn.py::test_trim_to_layer - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/nn/models/test_basic_gnn.py::test_basic_gnn_cache - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
FAILED test/utils/test_trim_to_layer.py::test_trim_to_layer_with_neighbor_loader - RuntimeError: pyg::neighbor_sample() Expected a value of type 'Optional[Tensor]' for argument 'edge_weight' but instead found type 'bool'.
All tests passed for 2.3.1 so I am downgrading.
Are you sure you are testing on latest PyG? It looks like you use an earlier version of PyG to test against.
Are you sure you are testing on latest PyG? It looks like you use an earlier version of PyG to test against.
I am pretty sure. The GraphMaskExplainer test is not in pyg < 2.4.0
Sorry, maybe this was confusing. Are you running the latest tests against PyG == 2.4.0 or against the latest version of PyG from master?
Sorry, maybe this was confusing. Are you running the latest tests against PyG == 2.4.0 or against the latest version of PyG from master?
2.4.0. I grabbed the tests from the latest release tarball (instead of cloning from git)
Got it, if you are running on fixed 2.4.0, then you will need pyg-lib==0.3.*
.
I'm seeing this Neighborloader issue even with pyg-lib==0.3.1
. Is there another potential fix?
Are you sure you are not on pyg-lib==0.4.0
(just released yesterday)? Support for it will be added in the next PyG version which we will release ASAP.
Yes—I was originally, but I downgraded after seeing your message above.
🐛 Describe the bug
After installing pytorch_geometric I ran the tests and got a lot of failures for some tests.
There are these
But a lot more are from test/explain/algorithm/test_graphmask_explainer.py. They are all like this
Examples of some more detailed logs on test_graphmask_explainer errors (there are too many)
Environment
conda
,pip
, source): piptorch-scatter
): torch-scatter 2.1.1