search

pyg-team / pytorch_geometric

Graph Neural Network Library for PyTorch
https://pyg.org
MIT License
20.95k stars 3.61k forks source link

Request to add Graph Normalizing Flows #897

Open johncava opened 4 years ago

johncava commented 4 years ago

🚀 Feature

Original Paper https://arxiv.org/abs/1905.13177

Original Paper TensorFlow Repo https://github.com/jliu/graph-normalizing-flows

Motivation A very interesting paper proposing an alternative graph generative model to GraphRNN using normalizing flows. I think it is beneficial to pytorch geometric as other papers such as https://arxiv.org/pdf/1909.13521.pdf have begun to add other flavors of normalizing flows for graph generation.

Thanks!

rusty1s commented 4 years ago

I see what I can do :)

murnanedaniel commented 4 years ago

@rusty1s Have you had a look at this yet? If not, I was interested in getting some normalizing flow module off the ground. But I don't want to re-invent the wheel if you've already made progress.

rusty1s commented 4 years ago

That would be great, I would very much appreciate this! Please feel free to send a PR :)

prateeky2806 commented 3 years ago

Hi @murnanedaniel, I plan to work on graph normalizing flows in my research project. I just wanted to check if the this is coming soon into pytorch-geometric or not.

murnanedaniel commented 3 years ago

Hi @prateeky2806, I didn't end up implementing this. My goal was to use the reversible nature of normalising flows in order to save memory when training, but the gradient checkpointing features in Pytorch ended up achieving this more easily. So if you would like to implement this, you should go right ahead!

thegodone commented 3 years ago

Hi guys any update in this PR ?