KennethNielsen
commented
9 years ago (by k-nielsen81) Hallo Byrial (I'll continue in english as I hope this program will eventually be used outside of Dansk-gruppen as well, so I think it is better if the bug reports are in english)
Thanks a lot for your bugreport. I'll group two of your issues together, as they pertain to the same behavior, namely what gets copied or removed when (de)activating in-inline commenting.
- When activating in-line commenting and there is already a comment in the comment field, only this comment will remain and the diff chunk will not be copied to the comment field
- When decativating in-line commenting, the comment field will keep all of the text that was there before, even if that text was all the diff chunk and nothing had been changed.
The reason for 1 is that I was worried of the comment growing, if the diff chunk was simply added to the comment everytime in-line commenting was activated, because I don't remove anything when we de-activate in-line commenting. This behavior was actually the one I original intended and then the idea was to add a function that you could use when you activate in-line mode, with an existing comment, that would copy the diff chunk to the place of the cursor and when deactivating in-line mode you would manually have to delete the diffchunk (This really shouldn't happen this often that you change your mind about whether to do in-line commeting or not). But since seeing your bugreport, I have thought a little about it and I think I have come up with a better way to make it work.
So the idea is to change it so that when activating in-line mode the diff chunk will always be copied to the beginning of the comment, so that if an existing comment is there, the diff chunk will simply be prefixed to it. And then when deactivating in-line mode, I'll see if the entire diff-chunk exists in an unbroken state in the comment, and if it does I'll remove the diff chunk part from the comment. I think that should take care of both points, what do you think?
The last thing that you mention is that when you deactivate in-line commenting mode the entire content of the "main" window will be copied to the comment window (even if nothing was changed). I think the last part has to do with what we discussed above, namely about removing the diff chunk from the comment when deac inline. But there is also a misunderstanding here about how the program works. There is no "main" windown. In ordinary mode, the top window is the diff window and the bottom window is the comment window. What happens when you activate in-line commenting mode is that the comment window is expanded to take up the entire space and the diff chunk is then copied to the comment window because we need it. This makes the comment window "look like" the diff window did before, but it is in fact still the comment window. So the content of the one window in inline mode is actually not copied to the comment window when you deac inline, it is simply kept, because it is the comment window.
The question is whether there is a real problem here in this misunderstanding, after we fix the other stuff above. Will this add some confusion to the usage. One way to possibly fix it is to add a headline to both of the fields so that you can always see which is what, on the other hand that also takes of screen space, so I would rather not do that unless it is necessary. What do you think?
Regards Kenneth (TLE)
Jeg har prøvet kommentering af en po-fil.
Når inline-kommentering slås til, vil man kun se den tidligere ikke-inline-kommentar hvis der er en.
Når inline-kommentering slås fra, vil alt hvad der står i hovedtekstfeltet blive kopieret til også at stå i kommentarfeltet nederst. Dette gælder endda også hvis intet er ændret.
Imported from Launchpad using lp2gh.