search

pygae / galgebra

Symbolic Geometric Algebra/Calculus package for SymPy :crystal_ball:
https://galgebra.rtfd.io/
BSD 3-Clause "New" or "Revised" License
233 stars 62 forks source link

Fix incorrect description of Hestenes inner product in examples #139

Open utensil opened 4 years ago

utensil commented 4 years ago

In https://nbviewer.jupyter.org/github/pygae/galgebra/blob/master/examples/ipython/inner_product.ipynb :

image

It's inconsistent with implementation and the original literature:

image

This should be corrected. And it's better to add some description of all three definitions:

image

from Geometric Algebra with Applications in Science and Engineering .

eric-wieser commented 4 years ago

It's inconsistent with implementation and the original literature

How so? Looks identical to the implementation and literature to me, if you start with the assumption that r and s are non-negative

utensil commented 4 years ago

image

This is particularly wrong (my own mistake). And the formula fails to mention how it should be like for arbitrary multivectors (i.e. the summing).

eric-wieser commented 4 years ago

Apart from the out of place "of", that sentence is true, isn't it?

And the formula fails to mention how it should be like for arbitrary multivectors

That's fair.

It might be worth adding the mathematical description to the docstring of hestenes_dot

utensil commented 4 years ago

Apart from the out of place "of", that sentence is true, isn't it?

No. It intended to describe how it works, not a consequence of how it works.