search

pygae / galgebra

Symbolic Geometric Algebra/Calculus package for SymPy :crystal_ball:
https://galgebra.rtfd.io/
BSD 3-Clause "New" or "Revised" License
233 stars 62 forks source link

Also fix `Fmt` to work correctly on Lt and Mlt instances #380

Closed eric-wieser closed 4 years ago

eric-wieser commented 4 years ago

Follow-up to #369, I forgot to check lt.py for the same pattern.

Mlt.Fmt was a weird outlier that called print rather than returning an object to be printed. Lt.Fmt had the same code commented out, so I guess this was just an incomplete transition to the return-style of Fmt.

The main effect of this will be to fix plaintext output in ipython of Lt and Mlt instances. I suspect we have no tests for that, but thankfully almost all of this code path is shared by Mv and Dop, so I think that's ok.

codecov[bot] commented 4 years ago

Codecov Report

Merging #380 into master will increase coverage by 0.35%. The diff coverage is 92.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   77.25%   77.60%   +0.35%     
==========================================
  Files          16       16              
  Lines        4313     4305       -8     
==========================================
+ Hits         3332     3341       +9     
+ Misses        981      964      -17
Impacted Files Coverage Δ
galgebra/lt.py 59.62% <58.33%> (+2.00%) :arrow_up:
galgebra/mv.py 75.15% <100.00%> (-0.76%) :arrow_down:
galgebra/printer.py 78.82% <100.00%> (+1.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06b387d...0b93b96. Read the comment docs.