Respect customizations made in sympy.init_printing

pygae / galgebra

Symbolic Geometric Algebra/Calculus package for SymPy :crystal_ball:

https://galgebra.rtfd.io/

BSD 3-Clause "New" or "Revised" License

233 stars 62 forks source link

Respect customizations made in sympy.init_printing #437

Closed eric-wieser closed 4 years ago

eric-wieser commented 4 years ago

In sympy 1.7, we can use the new base class to inherit the printer. In earlier versions, we have to poke around in IPython internals to find the appropriate printer.

This means that GaLatexPrinter is no longer used by default, but that's ok because:

All our examples either call Format to enable it, or use init_printing
GaLatexPrinter no longer does anything essential like it used to - all galgebra objects print to latex without it, all it adds is subjective tweaks to:
- Determinant printing
- Derivative printing
- Function printing (omitting arguments, subscripts)

eric-wieser commented 4 years ago

~~To make CI pass on this, we need to manually register latex printers for Mv, Lt, and Dop (as IPython ignores _repr_latex_ if the base class is manually registered)~~

Edit: Or, I just edit sympy upstream to make this work (sympy/sympy#19944) ;)

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 463611f242063b453c376959c521ef069fd823ba into 45455195fea27d7697e8e0fda18208b51efff71d - view on LGTM.com

new alerts:

1 for __eq__ not overridden when adding attributes

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging e1360f5304055a51798460b8cf8d2a5cbaf797c7 into 45455195fea27d7697e8e0fda18208b51efff71d - view on LGTM.com

new alerts:

1 for __eq__ not overridden when adding attributes